Page 1 of 1

Lagrange Module: user defined volumetric statistics

Posted: Tue Jul 05, 2011 1:23 pm
by Becker Ralf
Hello,
 
using the lagrange module with user defined statistics results in erroneous post-processing data.
 
In LAGOPT() the pointers to the arrays STATIS, STATIV are defined in the following order :

ILVX - ILVZ, ILFV, ILTS, ILVU(1:NVSTLS),  ILPD
ILPD, the pointer to the sum of the statistical weights,  is the last on as in  the subroutine DVVPST() all variables stored in STATIS but all except the last one of STATIV are written to the post-processing files.  This is because LAGSTA() does not calculate the variance of ILPD.

Contrary the routine DVVPST() expects the names NOMLAG(), NOMLAV() of the variables in STATIS, STATIV  in the order: names of variables defined by the code itself (ILVX..ILPD),
names of variables defined by the user (ILVU(1)..ILVU(NVSTLS)).

In consequence the sum of the statistical weights is stored with the name of the first user variable, and the first user variable is overwritten.
 
A patch  to DVVPST() based on  ncs-2.0.1 is attached.
 
Kind Regards,

Ralf Becker

Re: Lagrange Module: user defined volumetric statistics

Posted: Tue Jul 05, 2011 10:19 pm
by Yvan Fournier
Hello Ralph,
Thanks for your multiple patches regarding the Lagrangian module. I'll try to check with the Lagrangian module maintainers if they can check those patches rapidly (as we're getting ready to release 2.0.2, which is a maintenance (stable) release, and 2.1, which is a development release).
Best regards,
  Yvan